Skip to content

Code to change contrast#1060

Merged
cclauss merged 6 commits into
TheAlgorithms:masterfrom
QuantumNovice:master
Jul 21, 2019
Merged

Code to change contrast#1060
cclauss merged 6 commits into
TheAlgorithms:masterfrom
QuantumNovice:master

Conversation

@QuantumNovice

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread digital_image_processing/change_contrast.py
Comment thread digital_image_processing/change_contrast.py Outdated
Comment thread digital_image_processing/change_contrast.py Outdated
Comment thread digital_image_processing/change_contrast.py Outdated
@cclauss

cclauss commented Jul 21, 2019

Copy link
Copy Markdown
Member

If float works instead of int, then I am cool with that because it would deliver more fine-grained control but go with whatever works best for your algorithm.

@cclauss

cclauss commented Jul 21, 2019

Copy link
Copy Markdown
Member

👍 Cool to see that mypy is working...
https://travis-ci.org/TheAlgorithms/Python/builds/561654753#L563

Comment thread digital_image_processing/change_contrast.py

@QuantumNovice QuantumNovice left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge.

Comment thread digital_image_processing/change_contrast.py Outdated
Comment thread digital_image_processing/change_contrast.py Outdated
@QuantumNovice

Copy link
Copy Markdown
Contributor Author

What would you suggest for writing doc-tests for image processing algorithms?

@cclauss cclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great contribution. Thanks for your patience.

@cclauss cclauss merged commit 05e567c into TheAlgorithms:master Jul 21, 2019
@cclauss

cclauss commented Jul 21, 2019

Copy link
Copy Markdown
Member

I see a lot of repos use https://pypi.org/project/selenium to compare images on webpages but I have not done it myself.

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Add files via upload

* Update requirements.txt

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants